Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(139)

Issue 7432046: syscall: add Mmap tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dfc
Modified:
11 years ago
Reviewers:
minux1, cookieo9
Visibility:
Public.

Description

syscall: add Mmap tests Update issue 4929 A followup CL will add syscall constants and enable this test for for the remaining UNIX platforms.

Patch Set 1 #

Patch Set 2 : diff -r e73800eb2b00 https://code.google.com/p/go #

Patch Set 3 : diff -r 2f04e02f33c0 https://code.google.com/p/go #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
A src/pkg/syscall/mmap_test.go View 1 2 1 chunk +71 lines, -0 lines 3 comments Download

Messages

Total messages: 2
cookieo9
https://codereview.appspot.com/7432046/diff/5001/src/pkg/syscall/mmap_test.go File src/pkg/syscall/mmap_test.go (right): https://codereview.appspot.com/7432046/diff/5001/src/pkg/syscall/mmap_test.go#newcode23 src/pkg/syscall/mmap_test.go:23: _ = syscall.MAP_ANONYMOUS darwin doesn't have MAP_ANONYMOUS; it does ...
11 years, 1 month ago (2013-03-01 02:13:19 UTC) #1
minux1
11 years ago (2013-03-02 19:10:09 UTC) #2
https://codereview.appspot.com/7432046/diff/5001/src/pkg/syscall/mmap_test.go
File src/pkg/syscall/mmap_test.go (right):

https://codereview.appspot.com/7432046/diff/5001/src/pkg/syscall/mmap_test.go...
src/pkg/syscall/mmap_test.go:54: n, err := f.Write(make([]byte, 8192)) // larger
than a page
use syscall.Getpagesize()?

https://codereview.appspot.com/7432046/diff/5001/src/pkg/syscall/mmap_test.go...
src/pkg/syscall/mmap_test.go:63: b, err := syscall.Mmap(fd, 0, n, tt.prot,
tt.flag)
perhaps we could verify &b[0] is a valid address (and aligned to page size)?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b