Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 7430044: code review 7430044: syscall: add {Set,Get}priority for Linux, and consisten... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by minux1
Modified:
11 years, 9 months ago
Reviewers:
dave, iant
CC:
golang-dev, iant, bradfitz, dave_cheney.net
Visibility:
Public.

Description

syscall: add {Set,Get}priority for Linux, and consistency tests

Patch Set 1 #

Patch Set 2 : diff -r b766c6f23b62 https://code.google.com/p/go #

Patch Set 3 : diff -r b766c6f23b62 https://code.google.com/p/go #

Patch Set 4 : diff -r b766c6f23b62 https://code.google.com/p/go #

Patch Set 5 : diff -r 7e7041319c25 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 6 : diff -r 6415ff684316 https://code.google.com/p/go/ #

Patch Set 7 : diff -r f067fb74c22b https://code.google.com/p/go/ #

Patch Set 8 : diff -r 4aa7943034c5 https://code.google.com/p/go #

Patch Set 9 : diff -r 4aa7943034c5 https://code.google.com/p/go #

Patch Set 10 : diff -r e1e236ba6097 https://code.google.com/p/go/ #

Patch Set 11 : diff -r e1e236ba6097 https://code.google.com/p/go/ #

Patch Set 12 : diff -r 48f683178a60 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -2 lines) Patch
A src/pkg/syscall/consistency_unix_test.go View 1 1 chunk +25 lines, -0 lines 0 comments Download
M src/pkg/syscall/mkerrors.sh View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_linux.go View 1 2 3 4 5 6 7 4 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/zerrors_darwin_386.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_darwin_amd64.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_386.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_amd64.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_arm.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_386.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_amd64.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_arm.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_netbsd_386.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_netbsd_amd64.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_netbsd_arm.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_openbsd_386.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_openbsd_amd64.go View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_386.go View 1 2 chunks +21 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_amd64.go View 1 2 chunks +21 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_linux_arm.go View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years ago (2013-02-28 18:43:39 UTC) #1
minux1
*BSD already contains those two syscalls, but not required constants. the consistency check is RFC.
12 years ago (2013-02-28 18:44:43 UTC) #2
iant
Looks basically fine but clearly we can not commit it until the syscall is added ...
12 years ago (2013-02-28 18:59:52 UTC) #3
minux1
On Fri, Mar 1, 2013 at 2:59 AM, <iant@golang.org> wrote: > Looks basically fine but ...
12 years ago (2013-02-28 19:05:28 UTC) #4
bradfitz
https://codereview.appspot.com/7430044/diff/9001/src/pkg/syscall/consistency_unix_test.go File src/pkg/syscall/consistency_unix_test.go (right): https://codereview.appspot.com/7430044/diff/9001/src/pkg/syscall/consistency_unix_test.go#newcode15 src/pkg/syscall/consistency_unix_test.go:15: func _() { why do these vars and consts ...
12 years ago (2013-02-28 21:24:45 UTC) #5
dave_cheney.net
LGTM. The only comment I have is on the name of the test file, consistent_unix_test.go ...
12 years ago (2013-02-28 23:29:45 UTC) #6
minux1
any more opinions on this?
12 years ago (2013-03-04 18:52:07 UTC) #7
adg
I think it might be too late for this, and would urge you to leave ...
12 years ago (2013-03-05 23:37:37 UTC) #8
bradfitz
ping
11 years, 9 months ago (2013-06-05 01:09:16 UTC) #9
adg
11 years, 9 months ago (2013-06-05 01:32:10 UTC) #10
minux1
PTAL.
11 years, 9 months ago (2013-06-09 14:51:27 UTC) #11
iant
LGTM
11 years, 9 months ago (2013-06-10 18:01:59 UTC) #12
minux1
11 years, 9 months ago (2013-06-10 18:47:14 UTC) #13
*** Submitted as https://code.google.com/p/go/source/detail?r=b08e22305bcc ***

syscall: add {Set,Get}priority for Linux, and consistency tests

R=golang-dev, iant, bradfitz, dave
CC=golang-dev
https://codereview.appspot.com/7430044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b