Looks basically fine but clearly we can not commit it until the syscall is added
to the other Unix systems, or the test is moved to a different CL.
I would be curious to hear what others think of the test approach.
On Fri, Mar 1, 2013 at 2:59 AM, <iant@golang.org> wrote:
> Looks basically fine but clearly we can not commit it until the syscall
> is added to the other Unix systems, or the test is moved to a different
> CL.
>
To be clear, *BSD (including Darwin) already defines the two syscalls.
(if none of them has those two syscalls, I doubt we can add new APIs
at this stage)
I only added the syscalls to Linux and the three required constants to
all Unixes to be consistent and make them usable on *BSDs.
>
> I would be curious to hear what others think of the test approach.
>
me too.
https://codereview.appspot.com/7430044/diff/9001/src/pkg/syscall/consistency_unix_test.go File src/pkg/syscall/consistency_unix_test.go (right): https://codereview.appspot.com/7430044/diff/9001/src/pkg/syscall/consistency_unix_test.go#newcode15 src/pkg/syscall/consistency_unix_test.go:15: func _() { why do these vars and consts ...
I think it might be too late for this, and would urge you to leave it until
after Go 1.1 unless you feel very strongly about it.
http://golang.org/s/go11freeze
Issue 7430044: code review 7430044: syscall: add {Set,Get}priority for Linux, and consisten...
(Closed)
Created 12 years ago by minux1
Modified 11 years, 9 months ago
Reviewers:
Base URL:
Comments: 2