Issue 7421048: code review 7421048: image/png: always set up palette during DecodeConfig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7421048: code review 7421048: image/png: always set up palette during DecodeConfig (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by volker.dobler

Modified:
12 years ago

Reviewers:

CC:
golang-dev, nigeltao

Visibility:
Public.

Description

image/png: always set up palette during DecodeConfig The old code would decode the palette only for 8-bit images during a DecodeConfig. This CL keeps the behavior for 8-bit images and sets up the decoded palette also for 1, 2 and 4-bit images. Fixes issue 4279.

Patch Set 1 #

Patch Set 2 : diff -r 2fd26930dda2 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2fd26930dda2 https://code.google.com/p/go/ #

Total comments: 4

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -2 lines)			Patch
	M	src/pkg/image/png/reader.go	View	1	2 chunks	+6 lines, -2 lines	1 comment	Download
	M	src/pkg/image/png/reader_test.go	View	1	1 chunk	+27 lines, -0 lines	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

volker.dobler

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-03-01 16:57:46 UTC) #1

nigeltao

LGTM. https://codereview.appspot.com/7421048/diff/4001/src/pkg/image/png/reader.go File src/pkg/image/png/reader.go (right): https://codereview.appspot.com/7421048/diff/4001/src/pkg/image/png/reader.go#newcode690 src/pkg/image/png/reader.go:690: func (d *decoder) isPaletted() bool { I'd just ...

12 years ago (2013-03-04 03:54:22 UTC) #2

nigeltao

12 years ago (2013-03-04 03:54:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=67fc3cb0d3aa ***

image/png: always set up palette during DecodeConfig

The old code would decode the palette only for 8-bit
images during a DecodeConfig.
This CL keeps the behavior for 8-bit images and sets
up the decoded palette also for 1, 2 and 4-bit images.

Fixes issue 4279.

R=golang-dev, nigeltao
CC=golang-dev
https://codereview.appspot.com/7421048

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages