Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 7415044: code review 7415044: runtime: refactor Syscall benchmark (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by dvyukov
Modified:
12 years, 2 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

runtime: refactor Syscall benchmark And add a benchmark where #goroutines>GOMAXPROCS, because it's the most interesting case. Current results on darwin/amd64, Intel Core 2 Duo 2.13 GHz, 2 cores: BenchmarkSyscall 100000000 56.0 ns/op BenchmarkSyscall-2 50000000 57.2 ns/op BenchmarkSyscallWork 10000000 635 ns/op BenchmarkSyscallWork-2 10000000 315 ns/op BenchmarkSyscallExcess 1000000 2698 ns/op BenchmarkSyscallExcess-2 5000000 1192 ns/op BenchmarkSyscallExcessWork 1000000 2832 ns/op BenchmarkSyscallExcessWork-2 2000000 1966 ns/op

Patch Set 1 #

Patch Set 2 : diff -r 059a3cd9172d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 059a3cd9172d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 059a3cd9172d https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M src/pkg/runtime/proc_test.go View 1 2 chunks +15 lines, -22 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years, 2 months ago (2013-02-28 22:48:33 UTC) #1
r
LGTM
12 years, 2 months ago (2013-02-28 23:03:30 UTC) #2
dvyukov
12 years, 2 months ago (2013-02-28 23:12:27 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=4cdeb75811c7 ***

runtime: refactor Syscall benchmark
And add a benchmark where #goroutines>GOMAXPROCS,
because it's the most interesting case.
Current results on darwin/amd64, Intel Core 2 Duo 2.13 GHz, 2 cores:
BenchmarkSyscall	100000000	        56.0 ns/op
BenchmarkSyscall-2	50000000	        57.2 ns/op
BenchmarkSyscallWork	10000000	       635 ns/op
BenchmarkSyscallWork-2	10000000	       315 ns/op
BenchmarkSyscallExcess	 1000000	      2698 ns/op
BenchmarkSyscallExcess-2	 5000000	      1192 ns/op
BenchmarkSyscallExcessWork	 1000000	      2832 ns/op
BenchmarkSyscallExcessWork-2	 2000000	      1966 ns/op

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7415044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b