Issue 7409043: code review 7409043: go-tour: set PlayEnabled flag before parsing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7409043: code review 7409043: go-tour: set PlayEnabled flag before parsing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by adg

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

go-tour: set PlayEnabled flag before parsing initTour is called from init funcs in local.go and appengine.go, while PlayEnabled was being set by an init func in tour.go. It was possible that initTour would be called, rendering the tour, before PlayEnabled is set to true.

Patch Set 1 #

Patch Set 2 : diff -r d359c6b8e4c2 https://code.google.com/p/go-tour #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	gotour/tour.go	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

11 years, 2 months ago (2013-02-26 02:20:10 UTC) #1

adg

11 years, 2 months ago (2013-02-26 02:36:40 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=9d5982e4fe5c
***

go-tour: set PlayEnabled flag before parsing

initTour is called from init funcs in local.go and appengine.go,
while PlayEnabled was being set by an init func in tour.go.
It was possible that initTour would be called, rendering the tour,
before PlayEnabled is set to true.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7409043

Expand All Messages | Collapse All Messages