Issue 7405050: code review 7405050: libmach: many pe handling fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7405050: code review 7405050: libmach: many pe handling fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by brainman

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

libmach: many pe handling fixes - implement windows pread; - set correct Fhdr.type; - add ImageBase to all pe "virtual" addresses; - correct settext parameter order; - use pclntab/epclntab to find line numbers. Fixes issue 4841. Fixes issue 4926.

Patch Set 1 #

Patch Set 2 : diff -r f002e89cbd51 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f002e89cbd51 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fce50d680238 https://go.googlecode.com/hg/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -10 lines)			Patch
	M	src/libmach/executable.c	View	1	5 chunks	+25 lines, -8 lines	0 comments	Download
	M	src/libmach/windows.c	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 2 months ago (2013-02-27 06:28:53 UTC) #1

brainman

11 years, 2 months ago (2013-03-01 03:49:32 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=000120ff858a ***

libmach: many pe handling fixes

- implement windows pread;
- set correct Fhdr.type;
- add ImageBase to all pe "virtual" addresses;
- correct settext parameter order;
- use pclntab/epclntab to find line numbers.

Fixes issue 4841.
Fixes issue 4926.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7405050

Expand All Messages | Collapse All Messages