Issue 7405045: code review 7405045: runtime: remove PROT_EXEC from mmap calls.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7405045: code review 7405045: runtime: remove PROT_EXEC from mmap calls. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by minux1

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net, bradfitz

Visibility:
Public.

Description

runtime: remove PROT_EXEC from mmap calls. Executable heap is gone on Unix!

Patch Set 1 #

Patch Set 2 : diff -r 526fb7125a2f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 526fb7125a2f https://code.google.com/p/go/ #

Patch Set 4 : diff -r d7ae1953ef1b https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
M	src/pkg/runtime/mem_darwin.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/mem_freebsd.c	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/mem_linux.c	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/mem_netbsd.c	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/mem_openbsd.c	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2013-02-23 10:46:37 UTC) #1

dave_cheney.net

On 2013/02/23 10:46:37, minux wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

11 years, 2 months ago (2013-02-23 10:50:06 UTC) #2

minux1

Tested on Darwin/amd64, Linux/amd64, FreeBSD/amd64 and NetBSD/amd64.

11 years, 2 months ago (2013-02-23 11:21:19 UTC) #3

dave_cheney.net

LGTM on linux/386 and linux/arm On Sat, Feb 23, 2013 at 10:20 PM, minux <minux.ma@gmail.com> ...

11 years, 2 months ago (2013-02-23 14:26:03 UTC) #4

bradfitz

LGTM On Sat, Feb 23, 2013 at 3:20 AM, minux <minux.ma@gmail.com> wrote: > Tested on ...

11 years, 2 months ago (2013-02-23 20:07:03 UTC) #5

minux1

11 years, 2 months ago (2013-02-24 14:47:32 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=655b43c97d76 ***

runtime: remove PROT_EXEC from mmap calls.
Executable heap is gone on Unix!

R=golang-dev, dave, bradfitz
CC=golang-dev
https://codereview.appspot.com/7405045

Expand All Messages | Collapse All Messages