Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(670)

Issue 74010043: code review 74010043: runtime: temporary weaken a check in test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by dvyukov
Modified:
10 years ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, bradfitz, khr, rsc
Visibility:
Public.

Description

runtime: temporary weaken a check in test Currently the test fails as: $ go test -v -cpu 1,1,1,1 runtime -test.run=TestStack stack_test.go:1584: Stack inuse: want 4194304, got 18446744073709547520 Update issue 7468

Patch Set 1 #

Patch Set 2 : diff -r 3cd546ac3a99 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 3cd546ac3a99 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 3

Patch Set 4 : diff -r e0859f09474d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r e0859f09474d https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/pkg/runtime/stack_test.go View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years ago (2014-03-11 12:24:11 UTC) #1
bradfitz
https://codereview.appspot.com/74010043/diff/40001/src/pkg/runtime/stack_test.go File src/pkg/runtime/stack_test.go (right): https://codereview.appspot.com/74010043/diff/40001/src/pkg/runtime/stack_test.go#newcode1581 src/pkg/runtime/stack_test.go:1581: inuse := int64(s1.StackInuse - s0.StackInuse) do you mean int64(s1.StackInuse) ...
10 years ago (2014-03-11 17:31:33 UTC) #2
dvyukov
On 2014/03/11 17:31:33, bradfitz wrote: > https://codereview.appspot.com/74010043/diff/40001/src/pkg/runtime/stack_test.go > File src/pkg/runtime/stack_test.go (right): > > https://codereview.appspot.com/74010043/diff/40001/src/pkg/runtime/stack_test.go#newcode1581 > ...
10 years ago (2014-03-11 17:41:43 UTC) #3
bradfitz
https://codereview.appspot.com/74010043/diff/40001/src/pkg/runtime/stack_test.go File src/pkg/runtime/stack_test.go (right): https://codereview.appspot.com/74010043/diff/40001/src/pkg/runtime/stack_test.go#newcode1581 src/pkg/runtime/stack_test.go:1581: inuse := int64(s1.StackInuse - s0.StackInuse) On 2014/03/11 17:31:34, bradfitz ...
10 years ago (2014-03-11 17:48:08 UTC) #4
rsc
LGTM either way i think the intent is not terribly clear either way; the comment ...
10 years ago (2014-03-11 19:21:29 UTC) #5
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=33969a44cc3c *** runtime: temporary weaken a check in test Currently the test ...
10 years ago (2014-03-12 06:21:10 UTC) #6
gobot
10 years ago (2014-03-12 07:09:32 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the openbsd-386-rootbsd builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b