Issue 7393044: code review 7393044: gotour: Replace a hardcoding string with a template mark.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7393044: code review 7393044: gotour: Replace a hardcoding string with a template mark. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by mikespook

Modified:
9 years, 10 months ago

Reviewers:
adg

CC:
golang-dev

Visibility:
Public.

Description

gotour: Replace a hardcoding string with a template mark. Replace the hardcoding string ``A Tour of Go'' with a template mark ``{{.Title}}''. It will take a better user experience to the other language.

Patch Set 1 #

Patch Set 2 : diff -r a94b10649ed2 https://code.google.com/p/go-tour/ #

Patch Set 3 : diff -r a94b10649ed2 https://code.google.com/p/go-tour/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	template/tour.tmpl	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikespook

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour/

11 years, 2 months ago (2013-02-21 01:56:15 UTC) #1

adg

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=d359c6b8e4c2 *** gotour: Replace a hardcoding string with a template mark. Replace ...

11 years, 2 months ago (2013-02-21 02:07:09 UTC) #2

LGTM

Thanks.

Expand All Messages | Collapse All Messages