Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2074)

Issue 73920043: code review 73920043: syscall, net: clean up socket stub for solaris (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by mikio
Modified:
10 years, 1 month ago
Reviewers:
aram2, gobot, iant, aram
CC:
golang-codereviews, aram, iant
Visibility:
Public.

Description

syscall, net: clean up socket stub for solaris Solaris doesn't have struct ip_mreqn, instead it uses struct ip_mreq and struct group_req with struct sockaddr_storage. Also fixes incorrect SockaddrDatalink. Update issue 7399

Patch Set 1 : diff -r 3cd546ac3a99 https://code.google.com/p/go #

Patch Set 2 : diff -r 3a45c66fe455 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -47 lines) Patch
src/pkg/net/sockoptip_bsd.go View 1 chunk +1 line, -1 line 0 comments Download
src/pkg/net/sockoptip_posix.go View 1 chunk +1 line, -1 line 0 comments Download
src/pkg/net/sockoptip_stub.go View 1 chunk +26 lines, -21 lines 0 comments Download
src/pkg/syscall/syscall_solaris.go View 3 chunks +2 lines, -24 lines 0 comments Download

Messages

Total messages: 7
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 1 month ago (2014-03-11 08:20:33 UTC) #1
aram
LGTM
10 years, 1 month ago (2014-03-11 10:53:43 UTC) #2
gobot
R=iant@golang.org (assigned by mikioh.mikioh@gmail.com)
10 years, 1 month ago (2014-03-11 23:38:12 UTC) #3
iant
LGTM
10 years, 1 month ago (2014-03-12 01:03:58 UTC) #4
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=227a3d1d33b1 *** syscall, net: clean up socket stub for solaris Solaris doesn't ...
10 years, 1 month ago (2014-03-12 01:32:55 UTC) #5
gobot
This CL appears to have broken the windows-amd64 builder.
10 years, 1 month ago (2014-03-12 13:15:16 UTC) #6
aram2
10 years, 1 month ago (2014-03-12 13:21:26 UTC) #7
> This CL appears to have broken the windows-amd64 builder.

No, false alarm.

-- 
Aram Hăvărneanu
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b