Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(402)

Issue 7388056: code review 7388056: time: handle very large sleep durations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by adg
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, DMorsing, dfc, r
Visibility:
Public.

Description

time: handle very large sleep durations Fixes issue 4903.

Patch Set 1 #

Patch Set 2 : diff -r 33d3e7bbd3ef https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r 1d55e585ed6b https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r f387e9606ff3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M src/pkg/time/sleep.go View 1 2 4 chunks +19 lines, -4 lines 0 comments Download
M src/pkg/time/sleep_test.go View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2013-02-25 06:51:05 UTC) #1
DMorsing
Code LGTM, but are there any instances of this that is not a bug in ...
11 years, 1 month ago (2013-02-25 08:04:55 UTC) #2
adg
On 25 Feb 2013 19:04, <daniel.morsing@gmail.com> wrote: > > Code LGTM, but are there any ...
11 years, 1 month ago (2013-02-25 08:40:36 UTC) #3
dfc
Fixes issue 4903. On Mon, Feb 25, 2013 at 7:40 PM, Andrew Gerrand <adg@golang.org> wrote: ...
11 years, 1 month ago (2013-02-25 09:12:46 UTC) #4
r
https://codereview.appspot.com/7388056/diff/2001/src/pkg/time/sleep.go File src/pkg/time/sleep.go (right): https://codereview.appspot.com/7388056/diff/2001/src/pkg/time/sleep.go#newcode25 src/pkg/time/sleep.go:25: // when returns the time in unix nanos plus ...
11 years, 1 month ago (2013-02-25 17:40:38 UTC) #5
adg
Hello golang-dev@googlegroups.com, daniel.morsing@gmail.com, dave@cheney.net, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2013-02-25 21:34:47 UTC) #6
r
LGTM https://codereview.appspot.com/7388056/diff/10001/src/pkg/time/sleep_test.go File src/pkg/time/sleep_test.go (right): https://codereview.appspot.com/7388056/diff/10001/src/pkg/time/sleep_test.go#newcode297 src/pkg/time/sleep_test.go:297: func TestBadSleeps(t *testing.T) { // Test that sleeping ...
11 years, 1 month ago (2013-02-25 21:36:41 UTC) #7
adg
11 years, 1 month ago (2013-02-25 22:24:06 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=a7ea286f5569 ***

time: handle very large sleep durations

Fixes issue 4903.

R=golang-dev, daniel.morsing, dave, r
CC=golang-dev
https://codereview.appspot.com/7388056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b