code review 7378063: go/parser: more precise comment

go/parser: more precise comment

See also CL 7383051 for details.

[gri, 2013-02-25 05:54:06]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-02-25 05:56:52]

"it must it is a struct field" is not grammatical.
On Feb 24, 2013 9:54 PM, <gri@golang.org> wrote:

> Reviewers: adonovan,
>
> Message:
> Hello adonovan@google.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> go/parser: more precise comment
>
> See also CL 7383051 for details.
>
> Please review this at
https://codereview.appspot.**com/7378063/<https://codereview.appspot.com/7378...
>
> Affected files:
>   M src/pkg/go/parser/parser.go
>
>
> Index: src/pkg/go/parser/parser.go
> ==============================**==============================**=======
> --- a/src/pkg/go/parser/parser.go
> +++ b/src/pkg/go/parser/parser.go
> @@ -1229,11 +1229,11 @@
>         // In the former case we are done, and in the latter case we don't
>         // care because the type checker will do a separate field lookup.
>         //
> -       // If the key does not resolve, it must a) be defined at the top-
> -       // level in another file of the same package or be undeclared, or
> -       // b) it is a struct field. In the former case, the type checker
> -       // can do a top-level lookup, and in the latter case it will do a
> -       // separate field lookup.
> +       // If the key does not resolve, it must a) be defined at the top
> level
> +       // in another file of the same package, or the universe scope, or
> be
> +       // undeclared; or b) it is a struct field. In the former case, the
> type
> +       // checker can do a top-level lookup, and in the latter case it
> will do
> +       // a separate field lookup.
>         x := p.checkExpr(p.parseExpr(keyOk)**)
>         if keyOk {
>                 if p.tok == token.COLON {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[gri, 2013-02-25 06:01:01]

Hello adonovan@google.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adonovan, 2013-02-25 12:54:51]

LGTM

[gri, 2013-02-25 16:29:59]

*** Submitted as https://code.google.com/p/go/source/detail?r=08dc15884e88 ***

go/parser: more precise comment

See also CL 7383051 for details.

R=adonovan, bradfitz
CC=golang-dev
https://codereview.appspot.com/7378063