code review 7377055: go-tour: Fix introduction slide and a formatting error.

go-tour: Fix introduction slide and a formatting error.

[francesc, 2013-02-26 03:57:59]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go-tour

[adg, 2013-02-26 04:18:15]

https://codereview.appspot.com/7377055/diff/4001/tour.article
File tour.article (right):

https://codereview.appspot.com/7377055/diff/4001/tour.article#newcode24
tour.article:24: The tour is divided into three sections.
name the sections

https://codereview.appspot.com/7377055/diff/4001/tour.article#newcode25
tour.article:25: Along those sections, you will find a series of exercises for
you to complete.
Throughout the tour you will find...

https://codereview.appspot.com/7377055/diff/4001/tour.article#newcode370
tour.article:370: If you only want the index, drop the “, `value` ” entirely.
i think it should be this way, so it's all code formatted:

`"`,`value`"`

note that I changed the quotes to regular quotes

[francesc, 2013-02-26 06:03:17]

https://codereview.appspot.com/7377055/diff/4001/tour.article
File tour.article (right):

https://codereview.appspot.com/7377055/diff/4001/tour.article#newcode24
tour.article:24: The tour is divided into three sections.
On 2013/02/26 04:18:15, adg wrote:
> name the sections

Done.

https://codereview.appspot.com/7377055/diff/4001/tour.article#newcode25
tour.article:25: Along those sections, you will find a series of exercises for
you to complete.
On 2013/02/26 04:18:15, adg wrote:
> Throughout the tour you will find...

Done.

https://codereview.appspot.com/7377055/diff/4001/tour.article#newcode370
tour.article:370: If you only want the index, drop the “, `value` ” entirely.
I like better the way it looks when the quotes are not part of the
code-formatted part. I replaced the double quotes to regular ones.

Anyway, I don't feel strongly about this, so let me know if you want me to
change it.
On 2013/02/26 04:18:15, adg wrote:
> i think it should be this way, so it's all code formatted:
> 
> `"`,`value`"`
> 
> note that I changed the quotes to regular quotes

[adg, 2013-02-26 06:16:12]

https://codereview.appspot.com/7377055/diff/4001/tour.article
File tour.article (right):

https://codereview.appspot.com/7377055/diff/4001/tour.article#newcode370
tour.article:370: If you only want the index, drop the “, `value` ” entirely.
On 2013/02/26 06:03:17, gocampoy wrote:
> I like better the way it looks when the quotes are not part of the
> code-formatted part. I replaced the double quotes to regular ones.
> 
> Anyway, I don't feel strongly about this, so let me know if you want me to
> change it.

I'm a bit bothered that the comma isn't code formatted. :-/

> On 2013/02/26 04:18:15, adg wrote:
> > i think it should be this way, so it's all code formatted:
> > 
> > `"`,`value`"`
> > 
> > note that I changed the quotes to regular quotes
>

https://codereview.appspot.com/7377055/diff/9002/tour.article
File tour.article (right):

https://codereview.appspot.com/7377055/diff/9002/tour.article#newcode24
tour.article:24: The tour is divided into three sections: basic concepts,
composition, and concurrency.
s/composition/methods and interfaces/

https://codereview.appspot.com/7377055/diff/9002/tour.article#newcode371
tour.article:371: If you only want the index, drop the ", `value` " entirely.
just remove the backticks entirely.

[adg, 2013-02-26 21:53:44]

Ping. I would like to deploy these fixes.

[francesc, 2013-02-27 01:25:31]

PTAL

https://codereview.appspot.com/7377055/diff/9002/tour.article
File tour.article (right):

https://codereview.appspot.com/7377055/diff/9002/tour.article#newcode24
tour.article:24: The tour is divided into three sections: basic concepts,
composition, and concurrency.
On 2013/02/26 06:16:13, adg wrote:
> s/composition/methods and interfaces/

Done.

https://codereview.appspot.com/7377055/diff/9002/tour.article#newcode24
tour.article:24: The tour is divided into three sections: basic concepts,
composition, and concurrency.
On 2013/02/26 06:16:13, adg wrote:
> s/composition/methods and interfaces/

Done.

https://codereview.appspot.com/7377055/diff/9002/tour.article#newcode371
tour.article:371: If you only want the index, drop the ", `value` " entirely.
On 2013/02/26 06:16:13, adg wrote:
> just remove the backticks entirely.

Done.

[adg, 2013-02-27 01:32:51]

LGTM

[francesc, 2013-02-27 01:33:44]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=0bc41f02a195
***

go-tour: Fix introduction slide and a formatting error.

R=adg
CC=golang-dev
https://codereview.appspot.com/7377055