Issue 7375047: code review 7375047: net/url: fix URL Opaque notes on making client requests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7375047: code review 7375047: net/url: fix URL Opaque notes on making client requests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by bradfitz

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net/url: fix URL Opaque notes on making client requests Fixes issue 4860

Patch Set 1 #

Patch Set 2 : diff -r 67ff484a1801 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 67ff484a1801 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 67ff484a1801 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 0b99a705c0cc https://go.googlecode.com/hg/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/net/url/url.go	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 2 months ago (2013-02-21 21:06:34 UTC) #1

rsc

actually, not lgtm. doesn't the client still have to give a Host and Scheme so ...

11 years, 2 months ago (2013-02-21 21:16:12 UTC) #3

bradfitz

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 2 months ago (2013-02-21 21:19:47 UTC) #4

bradfitz

oh, duh, yes. PTAL. On Thu, Feb 21, 2013 at 1:16 PM, Russ Cox <rsc@golang.org> ...

11 years, 2 months ago (2013-02-21 21:19:49 UTC) #5

bradfitz

11 years, 2 months ago (2013-02-21 22:39:21 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=e641a237b2ad ***

net/url: fix URL Opaque notes on making client requests

Fixes issue 4860

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7375047

Expand All Messages | Collapse All Messages