Issue 7374045: code review 7374045: net/http: improve test reliability

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7374045: code review 7374045: net/http: improve test reliability (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by bradfitz

Modified:
11 years, 3 months ago

Reviewers:
dave

CC:
golang-dev, adg

Visibility:
Public.

Description

net/http: improve test reliability Fixes issue 4852

Patch Set 2 : diff -r d46d4fb24d4f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d46d4fb24d4f https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 127f96912009 https://go.googlecode.com/hg/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
	M	src/pkg/net/http/transport_test.go	View	1 2 3	8 chunks	+22 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 3 months ago (2013-02-20 16:45:04 UTC) #1

adg

LGTM https://codereview.appspot.com/7374045/diff/5001/src/pkg/net/http/transport_test.go File src/pkg/net/http/transport_test.go (right): https://codereview.appspot.com/7374045/diff/5001/src/pkg/net/http/transport_test.go#newcode1004 src/pkg/net/http/transport_test.go:1004: // Turn up the timeout longer, once. s/Turn ...

11 years, 3 months ago (2013-02-21 00:22:43 UTC) #2

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=0e91b66c0b7d *** net/http: improve test reliability Fixes issue 4852 R=golang-dev, adg CC=golang-dev ...

11 years, 3 months ago (2013-02-21 00:39:38 UTC) #3

dave_cheney.net

11 years, 3 months ago (2013-02-21 00:49:50 UTC) #4

Thanks Brad.

On Thu, Feb 21, 2013 at 11:39 AM,  <bradfitz@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=0e91b66c0b7d ***
>
>
> net/http: improve test reliability
>
> Fixes issue 4852
>
> R=golang-dev, adg
> CC=golang-dev
> https://codereview.appspot.com/7374045
>
>
>
> https://codereview.appspot.com/7374045/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

Expand All Messages | Collapse All Messages