Issue 7369055: code review 7369055: net/http: add Transport.ResponseHeaderTimeout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7369055: code review 7369055: net/http: add Transport.ResponseHeaderTimeout (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by bradfitz

Modified:
11 years, 1 month ago

Reviewers:

CC:
golang-dev, adg, rsc

Visibility:
Public.

Description

net/http: add Transport.ResponseHeaderTimeout Update issue 3362

Patch Set 1 #

Patch Set 2 : diff -r 6f89256bf255 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6f89256bf255 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f3e8dfc67e45 https://go.googlecode.com/hg/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -1 line)			Patch
	M	src/pkg/net/http/transport.go	View	1 2 3	4 chunks	+15 lines, -1 line	0 comments	Download
	M	src/pkg/net/http/transport_test.go	View	1 2 3	1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 1 month ago (2013-02-26 19:13:59 UTC) #1

adg

LGTM for implementation; reserving judgement on the API addition

11 years, 1 month ago (2013-02-27 03:11:56 UTC) #2

bradfitz

Calling Russ for API review. On Tue, Feb 26, 2013 at 7:11 PM, <adg@golang.org> wrote: ...

11 years, 1 month ago (2013-02-27 03:15:32 UTC) #3

bradfitz

Awesome... the new paranoid checks in https://code.google.com/p/go/source/detail?r=faf5a57def8cc09e86afdb6e884a35f9f93ddc09 found that this CL has a missing test ...

11 years, 1 month ago (2013-02-27 16:44:44 UTC) #5

bradfitz

11 years, 1 month ago (2013-02-27 16:47:11 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=02ee8f7b9a17 ***

net/http: add Transport.ResponseHeaderTimeout

Update issue 3362

R=golang-dev, adg, rsc
CC=golang-dev
https://codereview.appspot.com/7369055

Expand All Messages | Collapse All Messages