Issue 7369049: code review 7369049: cmd/vet: fix up some nits in print.go found by kamil.ki...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7369049: code review 7369049: cmd/vet: fix up some nits in print.go found by kamil.ki... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by r

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, kisielk, bradfitz

Visibility:
Public.

Description

cmd/vet: fix up some nits in print.go found by kamil.kisiel@gmail.com

Patch Set 2 : diff -r 17d4a0010fd8 https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/cmd/vet/print.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2013-02-24 18:54:30 UTC) #1

bradfitz

https://codereview.appspot.com/7369049/diff/1/src/cmd/vet/print.go File src/cmd/vet/print.go (right): https://codereview.appspot.com/7369049/diff/1/src/cmd/vet/print.go#newcode460 src/cmd/vet/print.go:460: return false why didn't the tests catch this?

11 years, 2 months ago (2013-02-24 19:03:30 UTC) #3

11 years, 2 months ago (2013-02-24 21:16:48 UTC) #4

11 years, 2 months ago (2013-02-24 21:18:38 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=3b285c00863b ***

cmd/vet: fix up some nits in print.go found by kamil.kisiel@gmail.com

R=golang-dev, kamil.kisiel, bradfitz
CC=golang-dev
https://codereview.appspot.com/7369049

Expand All Messages | Collapse All Messages