Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(713)

Issue 7369048: code review 7369048: cmd/gc: avoid runtime code generation for closures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by rsc
Modified:
12 years ago
Reviewers:
remyoudompheng
CC:
ken2, golang-dev
Visibility:
Public.

Description

cmd/gc: avoid runtime code generation for closures Change ARM context register to R7, to get out of the way of the register allocator during the compilation of the prologue statements (it wants to use R0 as a temporary). Step 2 of http://golang.org/s/go11func.

Patch Set 1 #

Patch Set 2 : diff -r 1852ee47001a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6a88e1893941 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6a88e1893941 https://code.google.com/p/go #

Patch Set 5 : diff -r 6a88e1893941 https://code.google.com/p/go #

Patch Set 6 : diff -r b469731ae7ec https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -445 lines) Patch
M src/cmd/5g/ggen.c View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M src/cmd/5g/gsubr.c View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download
M src/cmd/5g/peep.c View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/6g/ggen.c View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/6g/gsubr.c View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M src/cmd/6g/peep.c View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/8g/ggen.c View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/8g/gsubr.c View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M src/cmd/8g/peep.c View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/closure.c View 1 2 3 chunks +71 lines, -65 lines 0 comments Download
M src/cmd/gc/go.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/racewalk.c View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/gc/runtime.go View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/cmd/gc/typecheck.c View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M src/cmd/gc/walk.c View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
R src/pkg/runtime/closure_386.c View 1 2 1 chunk +0 lines, -108 lines 0 comments Download
R src/pkg/runtime/closure_amd64.c View 1 2 1 chunk +0 lines, -127 lines 0 comments Download
R src/pkg/runtime/closure_arm.c View 1 2 1 chunk +0 lines, -132 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years ago (2013-02-22 19:25:49 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=51f7d979c6e8 *** cmd/gc: avoid runtime code generation for closures Change ARM context ...
12 years ago (2013-02-22 19:25:54 UTC) #2
rsc
This broke Windows, as usual. I am looking into it.
12 years ago (2013-02-22 20:24:54 UTC) #3
remyoudompheng
12 years ago (2013-02-23 08:32:12 UTC) #4
On 2013/2/22  <rsc@golang.org> wrote:
> Description:
> cmd/gc: avoid runtime code generation for closures
>
> Change ARM context register to R7, to get out of the way
> of the register allocator during the compilation of the
> prologue statements (it wants to use R0 as a temporary).
>
> Step 2 of http://golang.org/s/go11func.
>
> Please review this at https://codereview.appspot.com/7369048/

Does it already make closure blobs eligible for escape analysis or do
we need a bit more work?

Rémy.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b