code review 7355043: go.net/spdy: make use of MaxDataLength

go.net/spdy: make use of MaxDataLength

[mikio, 2013-02-18 03:13:01]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net

[bradfitz, 2013-02-18 15:43:22]

LGTM

On Sun, Feb 17, 2013 at 7:13 PM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.**net <https://code.google.com/p/go.net>
>
>
> Description:
> go.net/spdy: make use of MaxDataLength
>
> Please review this at
https://codereview.appspot.**com/7355043/<https://codereview.appspot.com/7355...
>
> Affected files:
>   M spdy/write.go
>
>
> Index: spdy/write.go
> ==============================**==============================**=======
> --- a/spdy/write.go
> +++ b/spdy/write.go
> @@ -299,7 +299,7 @@
>         if frame.StreamId == 0 {
>                 return &Error{ZeroStreamId, 0}
>         }
> -       if frame.StreamId&0x80000000 != 0 || len(frame.Data) >= 0x0f000000
> {
> +       if frame.StreamId&0x80000000 != 0 || len(frame.Data) >
> MaxDataLength {
>                 return &Error{InvalidDataFrame, frame.StreamId}
>         }
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[mikio, 2013-02-18 15:47:19]

*** Submitted as
https://code.google.com/p/go/source/detail?r=d48de3be16b3&repo=net ***

go.net/spdy: make use of MaxDataLength

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7355043