Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(235)

Issue 7354043: code review 7354043: debug/dwarf: add flag_present attribute encoding. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by u
Modified:
11 years, 1 month ago
Reviewers:
CC:
minux1, iant, dfc, golang-dev
Visibility:
Public.

Description

debug/dwarf: add flag_present attribute encoding. ref: http://www.dwarfstd.org/doc/DWARF4.pdf Update issue 4829

Patch Set 1 #

Patch Set 2 : diff -r 3836bcbafa69 https://code.google.com/p/go #

Patch Set 3 : diff -r 28f7394b058f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/pkg/debug/dwarf/const.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/debug/dwarf/entry.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
minux1
hi u, do you mind submitting your changes to debug/dwarf for review now?
11 years, 1 month ago (2013-02-19 09:32:51 UTC) #1
u
Hello minux.ma@gmail.com (cc: dave@cheney.net, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2013-02-19 09:53:49 UTC) #2
minux1
Thank you. LGTM. Will wait for one more before submitting. Cross checked with DWARF standard. ...
11 years, 1 month ago (2013-02-19 10:11:43 UTC) #3
iant
LGTM
11 years, 1 month ago (2013-02-19 15:01:44 UTC) #4
minux1
11 years, 1 month ago (2013-02-19 16:58:45 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=8b51b7f3d2a6 ***

debug/dwarf: add flag_present attribute encoding.

ref: http://www.dwarfstd.org/doc/DWARF4.pdf

Update issue 4829

R=minux.ma, iant
CC=dave, golang-dev
https://codereview.appspot.com/7354043

Committer: Shenghou Ma <minux.ma@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b