Descriptioncmd/cgo, cmd/dist, cmd/go: cgo with clang fixes
1. Workaround the smart clang diagnostics with -Qunused-arguments:
clang: error: argument unused during compilation: '-XXX'
2. if "clang -print-libgcc-file-name" returns non-absolute path, don't
provide that on linker command line.
3. Fix dwarf.PtrType.Size() in cmd/cgo as clang doesn't generate
DW_AT_byte_size for pointer types.
4. Workaround warnings for -Wno-unneeded-internal-declaration with
-Wno-unknown-warning-option.
5. Add -Wno-unused-function.
6. enable race detector test on darwin with clang
(at least Apple clang version 1.7 (tags/Apple/clang-77) works).
Requires CL 7354043.
Update issue 4829
This should fix most parts of the problem, but one glitch still remains.
DWARF generated by newer clang doesn't differentiate these
two function types:
void *malloc(size_t);
void *malloc(unsigned long int);
so you might need to do this to make make.bash pass:
sed -i -e 's/C.malloc(C.size_t/C.malloc(C.ulong/' pkg/os/user/lookup_unix.go
Patch Set 1 #Patch Set 2 : diff -r 0adf91947752 https://code.google.com/p/go/ #Patch Set 3 : diff -r 6f23480a76e1 https://code.google.com/p/go/ #Patch Set 4 : diff -r 6f23480a76e1 https://code.google.com/p/go/ #Patch Set 5 : diff -r 6f23480a76e1 https://code.google.com/p/go/ #Patch Set 6 : diff -r 6f23480a76e1 https://code.google.com/p/go/ #Patch Set 7 : diff -r 6f23480a76e1 https://code.google.com/p/go/ #Patch Set 8 : diff -r 99c8e7dc4199 https://code.google.com/p/go/ #Patch Set 9 : diff -r dd18b993ba95 https://code.google.com/p/go/ #
Total comments: 3
Patch Set 10 : diff -r 526fb7125a2f https://code.google.com/p/go/ #Patch Set 11 : diff -r 526fb7125a2f https://code.google.com/p/go/ #
MessagesTotal messages: 14
|