Issue 7341051: code review 7341051: go.talks/pkg/socket: prevent use on AppEngine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7341051: code review 7341051: go.talks/pkg/socket: prevent use on AppEngine (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by bsiegert

Modified:
10 years, 10 months ago

Reviewers:
adg, dsymonds

CC:
adg, dsymonds, golang-dev

Visibility:
Public.

Description

go.talks/pkg/socket: prevent use on AppEngine This seems to fix my go.talks deployment on AppEngine. For some reason, the init function of the socket package is run, which checks for /tmp and exits if it does not exist.

Patch Set 1 #

Patch Set 2 : diff -r 6c92acb0bd16 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 6c92acb0bd16 https://code.google.com/p/go.talks #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	pkg/socket/socket.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsiegert

Hello adg@golang.org (cc: dsymonds@golang.org, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 2 months ago (2013-02-18 00:51:17 UTC) #1

dsymonds

LGTM The init function will be run if this file is part of the app ...

11 years, 2 months ago (2013-02-18 00:57:07 UTC) #2

bsiegert

Andrew, could you submit it please? I don't have submit rights.

11 years, 2 months ago (2013-02-18 01:51:25 UTC) #4

adg

11 years, 2 months ago (2013-02-18 02:03:06 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=44300c8546cc&repo=talks ***

go.talks/pkg/socket: prevent use on AppEngine

This seems to fix my go.talks deployment on AppEngine. For some reason,
the init function of the socket package is run, which checks for /tmp
and exits if it does not exist.

R=adg
CC=dsymonds, golang-dev
https://codereview.appspot.com/7341051

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages