Issue 7322086: code review 7322086: runtime: fix deadlock detector false negative

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7322086: code review 7322086: runtime: fix deadlock detector false negative (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dvyukov

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: fix deadlock detector false negative Fixes issue 4819.

Patch Set 1 #

Patch Set 2 : diff -r 59da6744d66d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 59da6744d66d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 59da6744d66d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 59da6744d66d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 59da6744d66d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r 1f57ae2a3e1c https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -19 lines)			Patch
src/pkg/runtime/crash_cgo_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
src/pkg/runtime/crash_test.go	View	1 2 3 4 5	3 chunks	+99 lines, -14 lines	0 comments	Download
src/pkg/runtime/proc.c	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 3 months ago (2013-02-15 19:36:19 UTC) #1

dvyukov

Just discovered that it hangs with GOMAXPROCS>1 e.g. GOMAXPROCS=2 go run test/fixedbugs/bug429.go actually hangs...

11 years, 3 months ago (2013-02-15 19:48:52 UTC) #3

dvyukov

On 2013/02/15 19:48:52, dvyukov wrote: > Just discovered that it hangs with GOMAXPROCS>1 > e.g. ...

11 years, 3 months ago (2013-02-15 20:00:43 UTC) #4

dvyukov

11 years, 2 months ago (2013-02-20 08:15:15 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=833cfd94e6dd ***

runtime: fix deadlock detector false negative
Fixes issue 4819.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7322086

Expand All Messages | Collapse All Messages