Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(459)

Issue 7322083: code review 7322083: runtime: make return from main wait for active panic (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

runtime: make return from main wait for active panic Arguably if this happens the program is buggy anyway, but letting the panic continue looks better than interrupting it. Otherwise things like this are possible, and confusing: $ go run x.go panic: $ echo $? 0 $ Fixes issue 3934.

Patch Set 1 #

Patch Set 2 : diff -r 19877242dd17 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ca70973f6b7a https://code.google.com/p/go/ #

Patch Set 4 : diff -r c4f97b9dd1d7 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/pkg/runtime/proc.c View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2013-02-15 04:36:40 UTC) #1
r
LGTM
11 years, 1 month ago (2013-02-15 05:24:25 UTC) #2
rsc
11 years, 1 month ago (2013-02-15 19:48:38 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=ba10d6b02282 ***

runtime: make return from main wait for active panic

Arguably if this happens the program is buggy anyway,
but letting the panic continue looks better than interrupting it.
Otherwise things like this are possible, and confusing:

$ go run x.go
panic: $ echo $?
0
$

Fixes issue 3934.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/7322083
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b