code review 7314104: cmd/go: reject case-insensitive file name, import collisions

cmd/go: reject case-insensitive file name, import collisions

To make sure that Go code will work when moved to a
system with a case-insensitive file system, like OS X or Windows,
reject any package built from files with names differing
only in case, and also any package built from imported
dependencies with names differing only in case.

Fixes issue 4773.

[rsc, 2013-02-15 04:11:59]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2013-02-15 18:34:53]

LGTM

https://codereview.appspot.com/7314104/diff/2001/src/cmd/go/main.go
File src/cmd/go/main.go (right):

https://codereview.appspot.com/7314104/diff/2001/src/cmd/go/main.go#newcode639
src/cmd/go/main.go:639: if clash[fold] != "" {
if t := clash[fold]; t != "" {

[rsc, 2013-02-15 19:39:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=c4f97b9dd1d7 ***

cmd/go: reject case-insensitive file name, import collisions

To make sure that Go code will work when moved to a
system with a case-insensitive file system, like OS X or Windows,
reject any package built from files with names differing
only in case, and also any package built from imported
dependencies with names differing only in case.

Fixes issue 4773.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7314104

[ality, 2013-02-20 12:36:48]

This CL added a test to cmd/go/test.bash that only
succeeds when using a case-insensitive file system.

When testing for case collisions in import paths
with a case-sensitive file system it prints:

	go list example/a should have failed, did not.

since len(p.DepsErrors) > 0. This is not a fatal
error when using go list.

  Anthony