code review 7312053: os: use windows ReadConsole to read from console

os: use windows ReadConsole to read from console

Fixes issue 4760.

[brainman, 2013-02-07 06:29:45]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[minux1, 2013-02-07 18:18:05]

https://codereview.appspot.com/7312053/diff/4001/src/pkg/os/file_windows.go
File src/pkg/os/file_windows.go (right):

https://codereview.appspot.com/7312053/diff/4001/src/pkg/os/file_windows.go#n...
src/pkg/os/file_windows.go:254: if len(b) > 0 {
i think we'd better check len(b) == 0 at the beginning,
as if len(b) == 0, no need to call ReadConsole will a nil
pointer.

[brainman, 2013-02-08 04:57:14]

https://codereview.appspot.com/7312053/diff/4001/src/pkg/os/file_windows.go
File src/pkg/os/file_windows.go (right):

https://codereview.appspot.com/7312053/diff/4001/src/pkg/os/file_windows.go#n...
src/pkg/os/file_windows.go:254: if len(b) > 0 {
What should I do if len(b) == 0?

[minux1, 2013-02-08 05:21:32]

On Fri, Feb 8, 2013 at 12:57 PM, <alex.brainman@gmail.com> wrote:

> https://codereview.appspot.**com/7312053/diff/4001/src/pkg/**
>
os/file_windows.go#newcode254<https://codereview.appspot.com/7312053/diff/4001/src/pkg/os/file_windows.go#newcode254>
> src/pkg/os/file_windows.go:**254: if len(b) > 0 {
> What should I do if len(b) == 0?
>
func (f *File) readConsole(b []byte) (n int, err error) {
   if len(b) == 0 { return 0, nil }
   if len(f.readbuf == 0) {
       wchars := make([]uint16, len(b))
       p := &wchars[0]
       var nm int32
       err := syscall.ReadConsole()
       // ....
   }

[brainman, 2013-02-11 04:27:48]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[brainman, 2013-02-26 02:50:24]

ping

[bradfitz, 2013-02-26 03:01:19]

LGTM

On Mon, Feb 25, 2013 at 6:50 PM, <alex.brainman@gmail.com> wrote:

> ping
>
>
https://codereview.appspot.**com/7312053/<https://codereview.appspot.com/7312...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[brainman, 2013-02-26 03:18:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=9d73a2fabea7 ***

os: use windows ReadConsole to read from console

Fixes issue 4760.

R=golang-dev, minux.ma, bradfitz
CC=golang-dev
https://codereview.appspot.com/7312053