Issue 7311092: code review 7311092: go.talks/pkg/present: remove remaining log.Fatal calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7311092: code review 7311092: go.talks/pkg/present: remove remaining log.Fatal calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by adg

Modified:
11 years, 2 months ago

Reviewers:

CC:
bsiegert, golang-dev

Visibility:
Public.

Description

go.talks/pkg/present: remove remaining log.Fatal calls

Patch Set 1 #

Patch Set 2 : diff -r 2202e5a97fc5 https://code.google.com/p/go.talks #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
	M	pkg/present/code.go	View		4 chunks	+17 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello bsiegert (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 2 months ago (2013-02-13 04:27:30 UTC) #1

adg

11 years, 2 months ago (2013-02-13 04:36:23 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=6c92acb0bd16&repo=talks ***

go.talks/pkg/present: remove remaining log.Fatal calls

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/7311092

Expand All Messages | Collapse All Messages