Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 7311081: code review 7311081: go-tour: add notes on translating the tour (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by adg
Modified:
11 years, 3 months ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

go-tour: add notes on translating the tour

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 1d45e5165405 https://code.google.com/p/go-tour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
A TRANSLATE View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 4
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour
11 years, 3 months ago (2013-02-12 04:59:24 UTC) #1
minux1
LGTM. https://codereview.appspot.com/7311081/diff/1/TRANSLATE File TRANSLATE (right): https://codereview.appspot.com/7311081/diff/1/TRANSLATE#newcode30 TRANSLATE:30: https://groups.google.com/group/go-tour-commits this group still needs approval for join. ...
11 years, 3 months ago (2013-02-12 16:49:12 UTC) #2
adg
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=8abefacdebca *** go-tour: add notes on translating the tour R=golang-dev, minux.ma CC=golang-dev ...
11 years, 3 months ago (2013-02-12 21:15:12 UTC) #3
adg
11 years, 3 months ago (2013-02-12 21:29:46 UTC) #4
On 13 February 2013 03:49, <minux.ma@gmail.com> wrote:

> this group still needs approval for join.
> i think its setting should mirror that of golang-checkins
> (anyone can join, only manager can post).
>

Yep, I changed the permissions. The groups management interface is
inscrutable!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b