Issue 7311044: code review 7311044: lib9: fix build for windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7311044: code review 7311044: lib9: fix build for windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by minux1

Modified:
12 years, 1 month ago

Reviewers:
ality

CC:
golang-dev, rsc

Visibility:
Public.

Description

lib9: fix build for windows

Patch Set 1 #

Patch Set 2 : diff -r 93266555c621 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 93266555c621 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 93266555c621 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 93266555c621 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 93266555c621 https://code.google.com/p/go/ #

Patch Set 7 : diff -r a9211b512258 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/lib9/main.c	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-02-05 16:25:02 UTC) #1

minux1

*** Submitted as https://code.google.com/p/go/source/detail?r=46db2dd7ba7c *** lib9: fix build for windows R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/7311044

12 years, 1 month ago (2013-02-05 16:33:41 UTC) #3

ality

12 years, 1 month ago (2013-02-05 16:38:39 UTC) #4

Russ Cox <rsc@golang.org> once said:
> LGTM
> 
> See ality's CL too. Not sure which is correct.

Not mine. :)

  Anthony

Expand All Messages | Collapse All Messages