code review 7310087: test: ensure all failing tests exit nonzero.

test: ensure all failing tests exit nonzero.

Previously merely printing an error would cause the golden
file comparison (in 'bash run') to fail, but that is no longer
the case with the new run.go driver.

[adonovan, 2013-02-12 17:04:12]

Hello iant@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2013-02-12 17:57:33]

LGTM

Thanks.

CL description is slightly inaccurate--we stopped using the golden.out file by
default a long time ago.  It's still available via "bash run" in the test
directory, but that is not run by default.

https://codereview.appspot.com/7310087/diff/7001/test/nil.go
File test/nil.go (right):

https://codereview.appspot.com/7310087/diff/7001/test/nil.go#newcode118
test/nil.go:118: println(x, ok) // unreachable
Might as well make it panic anyhow, I guess.

[adonovan, 2013-02-12 18:15:40]

https://codereview.appspot.com/7310087/diff/7001/test/nil.go
File test/nil.go (right):

https://codereview.appspot.com/7310087/diff/7001/test/nil.go#newcode118
test/nil.go:118: println(x, ok) // unreachable
On 2013/02/12 17:57:33, iant wrote:
> Might as well make it panic anyhow, I guess.

No need: the shouldBlock function panics if the closure runs to completion.

[adonovan, 2013-02-12 18:17:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=7b970f25d101 ***

test: ensure all failing tests exit nonzero.

Previously merely printing an error would cause the golden
file comparison (in 'bash run') to fail, but that is no longer
the case with the new run.go driver.

R=iant
CC=golang-dev
https://codereview.appspot.com/7310087