code review 7309054: go.talks/present: move included js files outside of sta...

go.talks/present: move included js files outside of static directory

When deployed to App Engine, directories listed in app.yaml
static_files directives are inaccessible to the running application.
This change allows the /play.js handler to read these JS files.

[adg, 2013-02-06 04:18:15]

Hello campoy@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[francesc, 2013-02-06 04:22:39]

https://codereview.appspot.com/7309054/diff/1002/present/local.go
File present/local.go (right):

https://codereview.appspot.com/7309054/diff/1002/present/local.go#newcode18
present/local.go:18: playScript(basePath, "socket.js")
basePath is defined in appengine.go, which I think is only built when on
AppEngine

Will this work locally?

Let me know if I'm wrong, it's probably

[adg, 2013-02-06 04:25:48]

On 6 February 2013 15:22, <campoy@golang.org> wrote:

> Will this work locally?
>
> Let me know if I'm wrong, it's probably
>

It's defined in appengine.go (appengine) and main.go (!appengine).

main.go should probably be rolled into local.go, or vice versa. (I'll do
this on another change.)

[francesc, 2013-02-06 04:37:54]

LGTM


On Tue, Feb 5, 2013 at 8:25 PM, Andrew Gerrand <adg@golang.org> wrote:

>
> On 6 February 2013 15:22, <campoy@golang.org> wrote:
>
>> Will this work locally?
>>
>> Let me know if I'm wrong, it's probably
>>
>
> It's defined in appengine.go (appengine) and main.go (!appengine).
>
> main.go should probably be rolled into local.go, or vice versa. (I'll do
> this on another change.)
>



-- 
--
Francesc

[dsymonds, 2013-02-06 04:38:16]

LGTM

[adg, 2013-02-06 04:38:53]

*** Submitted as
https://code.google.com/p/go/source/detail?r=4d416605f07c&repo=talks ***

go.talks/present: move included js files outside of static directory

When deployed to App Engine, directories listed in app.yaml
static_files directives are inaccessible to the running application.
This change allows the /play.js handler to read these JS files.

R=campoy, campoy, dsymonds
CC=golang-dev
https://codereview.appspot.com/7309054