code review 7308043: go.talks/pkg/socket: don't log EOF error; this is alway...

go.talks/pkg/socket: don't log EOF error; this is always benign

[adg, 2013-02-05 04:42:39]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[bradfitz, 2013-02-05 04:44:48]

LGTM

I assume it's also never nil here.

On Mon, Feb 4, 2013 at 8:42 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**talks <https://code.google.com/p/go.talks>
>
>
> Description:
> go.talks/pkg/socket: don't log EOF error; this is always benign
>
> Please review this at
https://codereview.appspot.**com/7308043/<https://codereview.appspot.com/7308...
>
> Affected files:
>   M pkg/socket/socket.go
>
>
> Index: pkg/socket/socket.go
> ==============================**==============================**=======
> --- a/pkg/socket/socket.go
> +++ b/pkg/socket/socket.go
> @@ -13,6 +13,7 @@
>
>  import (
>         "encoding/json"
> +       "io"
>         "io/ioutil"
>         "log"
>         "os"
> @@ -83,8 +84,10 @@
>                                 proc[m.Id].Kill()
>                         }
>                 case err := <-errc:
> -                       // A encode or decode has failed; bail.
> -                       log.Println(err)
> +                       if err != io.EOF {
> +                               // A encode or decode has failed; bail.
> +                               log.Println(err)
> +                       }
>                         // Shut down any running processes.
>                         for _, p := range proc {
>                                 p.Kill()
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[adg, 2013-02-05 04:46:23]

*** Submitted as
https://code.google.com/p/go/source/detail?r=af3fe4f44895&repo=talks ***

go.talks/pkg/socket: don't log EOF error; this is always benign

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7308043

[adg, 2013-02-05 04:46:30]

On 5 February 2013 15:44, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> I assume it's also never nil here.


I don't think it can be, no.