Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(571)

Issue 7307085: code review 7307085: go/parser: stop ParseFile after ten errors.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by matloob
Modified:
10 years, 8 months ago
Reviewers:
gri
CC:
golang-dev, gri
Visibility:
Public.

Description

go/parser: stop ParseFile after ten errors. There wil be a panic if more than ten errors are encountered. ParseFile will recover and return the ErrorList. Fixes issue 3943.

Patch Set 1 #

Patch Set 2 : diff -r a44171137af8 https://code.google.com/p/go #

Patch Set 3 : diff -r a44171137af8 https://code.google.com/p/go #

Total comments: 6

Patch Set 4 : diff -r a44171137af8 https://code.google.com/p/go #

Total comments: 5

Patch Set 5 : diff -r a44171137af8 https://code.google.com/p/go #

Total comments: 14

Patch Set 6 : diff -r 8c44c45a208e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -26 lines) Patch
M src/pkg/go/parser/error_test.go View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/go/parser/interface.go View 1 2 3 4 5 2 chunks +31 lines, -26 lines 0 comments Download
M src/pkg/go/parser/parser.go View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13
matloob
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2013-02-10 04:12:42 UTC) #1
gri
https://codereview.appspot.com/7307085/diff/4001/src/pkg/go/parser/interface.go File src/pkg/go/parser/interface.go (right): https://codereview.appspot.com/7307085/diff/4001/src/pkg/go/parser/interface.go#newcode61 src/pkg/go/parser/interface.go:61: SpuriousErrors // report all (not just the first) errors ...
11 years, 1 month ago (2013-02-10 06:25:04 UTC) #2
matloob
Hello golang-dev@googlegroups.com, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2013-02-10 07:03:57 UTC) #3
matloob
https://codereview.appspot.com/7307085/diff/4001/src/pkg/go/parser/interface.go File src/pkg/go/parser/interface.go (right): https://codereview.appspot.com/7307085/diff/4001/src/pkg/go/parser/interface.go#newcode61 src/pkg/go/parser/interface.go:61: SpuriousErrors // report all (not just the first) errors ...
11 years, 1 month ago (2013-02-10 07:04:34 UTC) #4
gri
https://codereview.appspot.com/7307085/diff/7003/src/pkg/go/parser/interface.go File src/pkg/go/parser/interface.go (right): https://codereview.appspot.com/7307085/diff/7003/src/pkg/go/parser/interface.go#newcode85 src/pkg/go/parser/interface.go:85: defer func() { move this past the readSource code ...
11 years, 1 month ago (2013-02-11 22:42:57 UTC) #5
matloob
Hello golang-dev@googlegroups.com, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2013-02-13 15:24:51 UTC) #6
matloob
https://codereview.appspot.com/7307085/diff/7003/src/pkg/go/parser/interface.go File src/pkg/go/parser/interface.go (right): https://codereview.appspot.com/7307085/diff/7003/src/pkg/go/parser/interface.go#newcode85 src/pkg/go/parser/interface.go:85: defer func() { On 2013/02/11 22:42:57, gri wrote: > ...
11 years, 1 month ago (2013-02-13 15:25:01 UTC) #7
gri
I think this is essentially what we want but in retrospect I think maybe we ...
11 years, 1 month ago (2013-02-14 06:55:56 UTC) #8
matloob
Hello golang-dev@googlegroups.com, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2013-02-14 16:10:17 UTC) #9
matloob
https://codereview.appspot.com/7307085/diff/10001/src/pkg/go/parser/interface.go File src/pkg/go/parser/interface.go (right): https://codereview.appspot.com/7307085/diff/10001/src/pkg/go/parser/interface.go#newcode60 src/pkg/go/parser/interface.go:60: SpuriousErrors // report all (not just the first) errors ...
11 years, 1 month ago (2013-02-14 16:10:21 UTC) #10
gri
LGTM thanks!
11 years, 1 month ago (2013-02-14 19:20:12 UTC) #11
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=e5cc27ee25e3 *** go/parser: stop ParseFile after ten errors. There wil be a ...
11 years, 1 month ago (2013-02-14 19:26:54 UTC) #12
remyoudompheng
10 years, 8 months ago (2013-07-21 10:18:55 UTC) #13
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b