code review 73070043: mime: update hardcoded mimetype for ".js"

mime: update hardcoded mimetype for ".js"
According to RFC 4329, it should be "application/javascript",
not "application/x-javascript".

[minux1, 2014-03-08 21:47:15]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-03-08 22:35:39]

I think we need more justification showing research that this is safe and
okay.

A document saying that it's correct is often not enough on the web.

Why do the libraries served from
https://developers.google.com/speed/libraries/devguide have text/javascript?

$ curl -A "Mozilla/5.0 (Windows NT 6.2; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/32.0.1667.0 Safari/537.36" -v
http://ajax.googleapis.com/ajax/libs/angularjs/1.2.12/angular.min.js 2>&1 |
grep Content-Type | head -1
< Content-Type: text/javascript; charset=UTF-8




On Sat, Mar 8, 2014 at 1:47 PM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> mime: update hardcoded mimetype for ".js"
> According to RFC 4329, it should be "application/javascript",
> not "application/x-javascript".
>
> Please review this at https://codereview.appspot.com/73070043/
>
> Affected files (+1, -1 lines):
>   M src/pkg/mime/type.go
>
>
> Index: src/pkg/mime/type.go
> ===================================================================
> --- a/src/pkg/mime/type.go
> +++ b/src/pkg/mime/type.go
> @@ -17,7 +17,7 @@
>         ".htm":  "text/html; charset=utf-8",
>         ".html": "text/html; charset=utf-8",
>         ".jpg":  "image/jpeg",
> -       ".js":   "application/x-javascript",
> +       ".js":   "application/javascript",
>         ".pdf":  "application/pdf",
>         ".png":  "image/png",
>         ".xml":  "text/xml; charset=utf-8",
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[gobot, 2014-07-16 11:03:05]

R=close (assigned by dave@cheney.net)