code review 7306087: test: a number of fixes.

test: a number of fixes.

Details:
- reorder.go: delete p8.
  (Once expectation is changed per b/4627 it is identical to p1.)
- switch.go: added some more (degenerate) switches.
- range.go: improved error messages in a few cases.
- method.go: added tests of calls to promoted methods.

[adonovan, 2013-02-11 20:51:36]

Hello iant@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2013-02-11 21:54:30]

https://codereview.appspot.com/7306087/diff/5002/test/reorder.go
File test/reorder.go (right):

https://codereview.appspot.com/7306087/diff/5002/test/reorder.go#newcode112
test/reorder.go:112: defer func() {
I don't see a reason to keep this defer function any more.  In the old code it
was needed because the code was supposed to panic.  We don't need a defer
function to test that code does not panic.  Just move the check to the last line
of the function and drop the defer entirely.

https://codereview.appspot.com/7306087/diff/5002/test/switch.go
File test/switch.go (right):

https://codereview.appspot.com/7306087/diff/5002/test/switch.go#newcode353
test/switch.go:353: // fallthrough to default, which is not at end.
I'm not I understand this comment--the default is at the end here.

[adonovan, 2013-02-11 22:22:07]

PTAL

https://codereview.appspot.com/7306087/diff/5002/test/reorder.go
File test/reorder.go (right):

https://codereview.appspot.com/7306087/diff/5002/test/reorder.go#newcode112
test/reorder.go:112: defer func() {
On 2013/02/11 21:54:30, iant wrote:
> I don't see a reason to keep this defer function any more.  In the old code it
> was needed because the code was supposed to panic.  We don't need a defer
> function to test that code does not panic.  Just move the check to the last
line
> of the function and drop the defer entirely.

Er, quite.

In fact this function is now identical to p1, so I have deleted it.

https://codereview.appspot.com/7306087/diff/5002/test/switch.go
File test/switch.go (right):

https://codereview.appspot.com/7306087/diff/5002/test/switch.go#newcode353
test/switch.go:353: // fallthrough to default, which is not at end.
On 2013/02/11 21:54:30, iant wrote:
> I'm not I understand this comment--the default is at the end here.

Hmmm... I can't explain that.  I've added another case after the default.

I also added another test with a fallthrough in the final case.

[iant, 2013-02-11 23:05:20]

LGTM

[adonovan, 2013-02-11 23:20:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=3784284ab5d0 ***

test: a number of fixes.

Details:
- reorder.go: delete p8.
  (Once expectation is changed per b/4627 it is identical to p1.)
- switch.go: added some more (degenerate) switches.
- range.go: improved error messages in a few cases.
- method.go: added tests of calls to promoted methods.

R=iant
CC=golang-dev
https://codereview.appspot.com/7306087