Issue 7306060: code review 7306060: go-tour: move javascript files from static to new js di...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7306060: code review 7306060: go-tour: move javascript files from static to new js di... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by adg

Modified:
11 years, 3 months ago

Reviewers:

CC:
dsymonds, golang-dev

Visibility:
Public.

Description

go-tour: move javascript files from static to new js directory This permits the App Engine app to actually access the JS files when serving /script.js. (Inside static/ they are considered static content and are unavailable to the running app in production.)

Patch Set 1 #

Patch Set 2 : diff -r 27a7bbbb02c9 https://code.google.com/p/go-tour #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-5 lines, --5 lines)			Patch
M	gotour/appengine.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gotour/local.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	js/codemirror/lib/codemirror.js	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	js/codemirror/lib/go.js	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	js/jquery.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	js/lang.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	js/playground.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	js/socket.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	js/tour.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello dsymonds (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

11 years, 3 months ago (2013-02-07 01:46:52 UTC) #1

adg

11 years, 3 months ago (2013-02-07 02:40:12 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=91ffba3b8d86
***

go-tour: move javascript files from static to new js directory

This permits the App Engine app to actually access the JS files when
serving /script.js. (Inside static/ they are considered static content
and are unavailable to the running app in production.)

R=dsymonds
CC=golang-dev
https://codereview.appspot.com/7306060

Expand All Messages | Collapse All Messages