Issue 7305094: code review 7305094: go-tour: honor -http argument in websocket code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7305094: code review 7305094: go-tour: honor -http argument in websocket code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by adg

Modified:
11 years, 3 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

go-tour: honor -http argument in websocket code

Patch Set 1 #

Patch Set 2 : diff -r d60c85ceb156 https://code.google.com/p/go-tour #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -7 lines)			Patch
M	gotour/appengine.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gotour/local.go	View	5 chunks	+11 lines, -3 lines	0 comments	Download
M	gotour/tour.go	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	js/tour.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	template/tour.tmpl	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

11 years, 3 months ago (2013-02-15 00:12:04 UTC) #1

adg

11 years, 3 months ago (2013-02-15 00:15:24 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=63e5086cfc87
***

go-tour: honor -http argument in websocket code

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/7305094

Expand All Messages | Collapse All Messages