code review 7305049: go-tour: use new playground API and websocket backend

go-tour: use new playground API and websocket backend

[adg, 2013-02-06 05:43:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go-tour

[francesc, 2013-02-06 18:13:22]

Where can I find the new playground API and the websocket backend
definition?
Is it in a different issue? It would be helpful to review this

Thanks


On Tue, Feb 5, 2013 at 9:43 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go-**tour <https://code.google.com/p/go-tour>
>
>
> Description:
> go-tour: use new playground API and websocket backend
>
> Please review this at
https://codereview.appspot.**com/7305049/<https://codereview.appspot.com/7305...
>
> Affected files:
>   M app.yaml
>   M gotour/appengine.go
>   M gotour/local.go
>   M gotour/tour.go
>   M static/lang.js
>   A static/playground.js
>   A static/socket.js
>   M static/tour.css
>   M static/tour.js
>   M template/tour.tmpl
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>


-- 
--
Francesc

[adg, 2013-02-06 21:43:29]

I don't have a definition of the API handy, but the JavaScript in socket.js
and playground.js is just a copy of the code from present, so there is
actually very little new code in this cl.

If you have any specific questions I can help.
On 7 Feb 2013 05:13, "Francesc Campoy Flores" <campoy@golang.org> wrote:

> Where can I find the new playground API and the websocket backend
> definition?
> Is it in a different issue? It would be helpful to review this
>
> Thanks
>
>
> On Tue, Feb 5, 2013 at 9:43 PM, <adg@golang.org> wrote:
>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go-**tour <https://code.google.com/p/go-tour>
>>
>>
>> Description:
>> go-tour: use new playground API and websocket backend
>>
>> Please review this at
https://codereview.appspot.**com/7305049/<https://codereview.appspot.com/7305...
>>
>> Affected files:
>>   M app.yaml
>>   M gotour/appengine.go
>>   M gotour/local.go
>>   M gotour/tour.go
>>   M static/lang.js
>>   A static/playground.js
>>   A static/socket.js
>>   M static/tour.css
>>   M static/tour.js
>>   M template/tour.tmpl
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
>> .
>> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
>> .
>>
>>
>>
>
>
> --
> --
> Francesc
>

[adg, 2013-02-06 23:46:30]

I'm also happy for you to ignore the javascript part entirely.

[francesc, 2013-02-07 00:01:34]

https://codereview.appspot.com/7305049/diff/3/gotour/tour.go
File gotour/tour.go (right):

https://codereview.appspot.com/7305049/diff/3/gotour/tour.go#newcode79
gotour/tour.go:79: scripts = append(scripts, "tour.js")
Why is "tour.js" not in commonScripts?

[adg, 2013-02-07 00:13:02]

On 2013/02/07 00:01:34, gocampoy wrote:
> https://codereview.appspot.com/7305049/diff/3/gotour/tour.go
> File gotour/tour.go (right):
> 
> https://codereview.appspot.com/7305049/diff/3/gotour/tour.go#newcode79
> gotour/tour.go:79: scripts = append(scripts, "tour.js")
> Why is "tour.js" not in commonScripts?

It must always be included last.

[francesc, 2013-02-07 00:14:20]

On 2013/02/07 00:13:02, adg wrote:
> On 2013/02/07 00:01:34, gocampoy wrote:
> > https://codereview.appspot.com/7305049/diff/3/gotour/tour.go
> > File gotour/tour.go (right):
> > 
> > https://codereview.appspot.com/7305049/diff/3/gotour/tour.go#newcode79
> > gotour/tour.go:79: scripts = append(scripts, "tour.js")
> > Why is "tour.js" not in commonScripts?
> 
> It must always be included last.

LGTM but I didn't review the javascript part

[adg, 2013-02-07 00:56:35]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=27a7bbbb02c9
***

go-tour: use new playground API and websocket backend

R=golang-dev, campoy
CC=golang-dev
https://codereview.appspot.com/7305049