code review 7305043: archive/tar: small simplification using FileMode.

archive/tar: small simplification using FileMode.

[dsymonds, 2013-02-05 04:06:56]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-02-05 04:18:39]

LGTM

On Mon, Feb 4, 2013 at 8:06 PM, <dsymonds@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> archive/tar: small simplification using FileMode.
>
> Please review this at
https://codereview.appspot.**com/7305043/<https://codereview.appspot.com/7305...
>
> Affected files:
>   M src/pkg/archive/tar/common.go
>
>
> Index: src/pkg/archive/tar/common.go
> ==============================**==============================**=======
> --- a/src/pkg/archive/tar/common.**go
> +++ b/src/pkg/archive/tar/common.**go
> @@ -80,7 +80,7 @@
>                 Mode:    int64(fi.Mode().Perm()), // or'd with c_IS*
> constants later
>         }
>         switch {
> -       case fi.Mode()&os.ModeType == 0:
> +       case fi.Mode().IsRegular():
>                 h.Mode |= c_ISREG
>                 h.Typeflag = TypeReg
>                 h.Size = fi.Size()
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[dsymonds, 2013-02-05 04:40:01]

*** Submitted as https://code.google.com/p/go/source/detail?r=fceaf0ddea29 ***

archive/tar: small simplification using FileMode.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7305043