Issue 7303043: code review 7303043: cmd/gc: fix escape analysis

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7303043: code review 7303043: cmd/gc: fix escape analysis (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by rsc

Modified:
12 years, 1 month ago

Reviewers:
dave, ken3

CC:
ken2, golang-dev, lvd1

Visibility:
Public.

Description

cmd/gc: fix escape analysis If the analysis reached a node twice, then the analysis was cut off. However, if the second arrival is at a lower depth (closer to escaping) then it is important to repeat the traversal. The repeating must be cut off at some point to avoid the occasional infinite recursion. This CL cuts it off as soon as possible while still passing all tests. Fixes issue 4751.

Patch Set 1 #

Patch Set 2 : diff -r e2f9b9a58240 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a49ff1ff1a55 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -4 lines)			Patch
M	src/cmd/gc/esc.c	View	1	3 chunks	+24 lines, -4 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/escape2.go	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com, lvd@golang.org), I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-02-05 03:48:29 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=1f343d81deab *** cmd/gc: fix escape analysis If the analysis reached a node ...

12 years, 1 month ago (2013-02-05 03:48:35 UTC) #2

dave_cheney.net

12 years, 1 month ago (2013-02-05 03:57:39 UTC) #4

Thanks for your quick action Russ. I can confirm this has fixed the
breakage in our code.

On Tue, Feb 5, 2013 at 2:48 PM,  <rsc@golang.org> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=1f343d81deab ***
>
>
> cmd/gc: fix escape analysis
>
> If the analysis reached a node twice, then the analysis was cut off.
> However, if the second arrival is at a lower depth (closer to escaping)
> then it is important to repeat the traversal.
>
> The repeating must be cut off at some point to avoid the occasional
> infinite recursion. This CL cuts it off as soon as possible while still
> passing all tests.
>
> Fixes issue 4751.
>
> R=ken2
> CC=golang-dev, lvd
> https://codereview.appspot.com/7303043
>
>
> https://codereview.appspot.com/7303043/
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

Expand All Messages | Collapse All Messages