code review 7301043: net/http: fix Server blocking after a Handler's Write fails

net/http: fix Server blocking after a Handler's Write fails

If a Handle's Write to a ResponseWriter fails (e.g. via a
net.Conn WriteDeadline via WriteTimeout on the Server), the
Server was blocking forever waiting for reads on that
net.Conn, even after a Write failed.

Instead, once we see a Write fail, close the connection,
since it's then dead to us anyway.

Fixes issue 4741

[bradfitz, 2013-02-05 01:23:31]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2013-02-05 02:01:30]

LGTM

[bradfitz, 2013-02-05 04:26:20]

*** Submitted as https://code.google.com/p/go/source/detail?r=6e182f07ef77 ***

net/http: fix Server blocking after a Handler's Write fails

If a Handle's Write to a ResponseWriter fails (e.g. via a
net.Conn WriteDeadline via WriteTimeout on the Server), the
Server was blocking forever waiting for reads on that
net.Conn, even after a Write failed.

Instead, once we see a Write fail, close the connection,
since it's then dead to us anyway.

Fixes issue 4741

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7301043

[adg, 2013-02-05 04:27:30]

If there's one major selling point for goroutines and channels it's writing
these http tests.

[bradfitz, 2013-02-05 04:30:19]

Yeah, I love many moving parts can communicate so succinctly.  Still hasn't
lost its novelty.

On Mon, Feb 4, 2013 at 8:26 PM, Andrew Gerrand <adg@golang.org> wrote:

> If there's one major selling point for goroutines and channels it's
> writing these http tests.
>