Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(946)

Issue 7300108: code review 7300108: encoding/json: roll back Unmarshal optimization + test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

encoding/json: roll back Unmarshal optimization + test The second attempt at the Unmarshal optimization allowed panics to get out of the json package. Add test for that bug and remove the optimization. Let's stop trying to optimize Unmarshal. Fixes issue 4784.

Patch Set 1 #

Patch Set 2 : diff -r 31065f4dbca5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 476df039c1b7 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M src/pkg/encoding/json/decode.go View 1 2 chunks +1 line, -19 lines 0 comments Download
M src/pkg/encoding/json/decode_test.go View 1 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2013-02-14 16:23:59 UTC) #1
bradfitz
LGTM
11 years, 1 month ago (2013-02-14 16:32:11 UTC) #2
rsc
11 years, 1 month ago (2013-02-14 19:46:53 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=f61076103b8e ***

encoding/json: roll back Unmarshal optimization + test

The second attempt at the Unmarshal optimization allowed
panics to get out of the json package. Add test for that bug
and remove the optimization.

Let's stop trying to optimize Unmarshal.

Fixes issue 4784.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7300108
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b