code review 7300044: go.talks/pkg/socket: send compiler output to stderr

go.talks/pkg/socket: send compiler output to stderr

[adg, 2013-02-05 04:16:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[bradfitz, 2013-02-05 04:20:25]

LGTM

On Mon, Feb 4, 2013 at 8:16 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**talks <https://code.google.com/p/go.talks>
>
>
> Description:
> go.talks/pkg/socket: send compiler output to stderr
>
> Please review this at
https://codereview.appspot.**com/7300044/<https://codereview.appspot.com/7300...
>
> Affected files:
>   M pkg/socket/socket.go
>
>
> Index: pkg/socket/socket.go
> ==============================**==============================**=======
> --- a/pkg/socket/socket.go
> +++ b/pkg/socket/socket.go
> @@ -152,6 +152,7 @@
>         defer os.Remove(bin)
>         dir, file := filepath.Split(src)
>         cmd := p.cmd(dir, "go", "build", "-o", bin, file)
> +       cmd.Stdout = cmd.Stderr // send compiler output to stderr
>         if err := cmd.Run(); err != nil {
>                 return err
>         }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[adg, 2013-02-05 04:22:27]

*** Submitted as
https://code.google.com/p/go/source/detail?r=6fdcb4795d29&repo=talks ***

go.talks/pkg/socket: send compiler output to stderr

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7300044