Issue 7297043: code review 7297043: go.talks: move websocket backend code to its own package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7297043: code review 7297043: go.talks: move websocket backend code to its own package (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by adg

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, francesc

Visibility:
Public.

Description

go.talks: move websocket backend code to its own package This makes it easier to include it in other programs, like the Tour.

Patch Set 2 : diff -r 2c25ae98203b https://code.google.com/p/go.talks #

Total comments: 4

Patch Set 3 : diff -r 2c25ae98203b https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 4ddd84d9fe51 https://code.google.com/p/go.talks #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -27 lines)			Patch
	M	pkg/socket/socket.go	View	1 2	11 chunks	+27 lines, -27 lines	0 comments	Download
	A	present/local.go	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 2 months ago (2013-02-05 00:03:13 UTC) #1

francesc

https://codereview.appspot.com/7297043/diff/2001/pkg/socket/socket.go File pkg/socket/socket.go (right): https://codereview.appspot.com/7297043/diff/2001/pkg/socket/socket.go#newcode6 pkg/socket/socket.go:6: // Clients connect to a websocket handler and sends ...

11 years, 2 months ago (2013-02-05 01:05:20 UTC) #2

adg

PTAL https://codereview.appspot.com/7297043/diff/2001/pkg/socket/socket.go File pkg/socket/socket.go (right): https://codereview.appspot.com/7297043/diff/2001/pkg/socket/socket.go#newcode6 pkg/socket/socket.go:6: // Clients connect to a websocket handler and ...

11 years, 2 months ago (2013-02-05 01:37:18 UTC) #3

adg

11 years, 2 months ago (2013-02-05 04:07:01 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=ad29729c589e&repo=talks ***

go.talks: move websocket backend code to its own package

This makes it easier to include it in other programs, like the Tour.

R=golang-dev, campoy
CC=golang-dev
https://codereview.appspot.com/7297043

Expand All Messages | Collapse All Messages