code review 7288056: cmd/dist: add -Wstrict-prototypes to CFLAGS and fix all...

cmd/dist: add -Wstrict-prototypes to CFLAGS and fix all the compiler errors
Plan 9 compilers insist this but as we don't have Plan 9
builders, we'd better let gcc check the prototypes.

Inspired by CL 7289050.

[akumar, 2013-02-04 21:29:06]

LGTM.

https://codereview.appspot.com/7288056/diff/2001/src/cmd/dist/build.c
File src/cmd/dist/build.c (right):

https://codereview.appspot.com/7288056/diff/2001/src/cmd/dist/build.c#newcode411
src/cmd/dist/build.c:411: "-Wstrict-prototypes",
Maybe move this line up, to just after -Werror, just to collect all the warning
switches in one block?

[minux1, 2013-02-04 21:53:55]

Hello golang-dev@googlegroups.com, seed@mail.nanosouffle.net (cc:
akumar@mail.nanosouffle.net, golang-dev@googlegroups.com, lucio.dere@gmail.com),

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2013-02-05 01:20:05]

LGTM. Tested on a few hosts that I have and nothing complained.

[rsc, 2013-02-05 02:56:56]

LGTM

[lucio, 2013-02-05 04:21:14]

Thanks, Minux, I'll withdraw my CL.

Lucio.

https://codereview.appspot.com/7288056/diff/10002/src/libmach/darwin.c
File src/libmach/darwin.c (right):

https://codereview.appspot.com/7288056/diff/10002/src/libmach/darwin.c#newcod...
src/libmach/darwin.c:754: extern boolean_t exc_server(mach_msg_header_t *,
mach_msg_header_t *);
I can't check if the corresponding declaration of mach_msg_server() matches, but
either way it should not affect compilation in the Native Plan 9 environment.

[minux1, 2013-02-05 13:43:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=93266555c621 ***

cmd/dist: add -Wstrict-prototypes to CFLAGS and fix all the compiler errors
Plan 9 compilers insist this but as we don't have Plan 9
builders, we'd better let gcc check the prototypes.

Inspired by CL 7289050.

R=golang-dev, seed, dave, rsc, lucio.dere
CC=akumar, golang-dev
https://codereview.appspot.com/7288056