Issue 7288047: code review 7288047: xml: xml.MarshalIndent to not include newline at start ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7288047: code review 7288047: xml: xml.MarshalIndent to not include newline at start ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by shiv

Modified:
11 years, 2 months ago

Reviewers:
rsc, dave, golang-dev

CC:
golang-dev

Visibility:
Public.

Description

xml: xml.MarshalIndent to not include newline at start of xml. Fixes issue 3354

Patch Set 2 : diff -r c23760174a83 https://code.google.com/p/go #

Patch Set 3 : diff -r c23760174a83 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r c23760174a83 https://code.google.com/p/go #

Patch Set 5 : diff -r c23760174a83 https://code.google.com/p/go #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -1 line)			Patch
	M	src/pkg/encoding/xml/marshal.go	View	1 2 3 4	2 chunks	+6 lines, -1 line	0 comments	Download
	M	src/pkg/encoding/xml/marshal_test.go	View	1 2 3	3 chunks	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

shiv

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 2 months ago (2013-02-03 10:10:22 UTC) #1

dave_cheney.net

Thank you for this proposal. Please add a test. https://codereview.appspot.com/7288047/diff/5001/src/pkg/encoding/xml/marshal.go File src/pkg/encoding/xml/marshal.go (right): https://codereview.appspot.com/7288047/diff/5001/src/pkg/encoding/xml/marshal.go#newcode127 src/pkg/encoding/xml/marshal.go:127: ...

11 years, 2 months ago (2013-02-03 10:14:17 UTC) #2

shiv

Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 2 months ago (2013-02-03 12:28:13 UTC) #3

shiv

Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 2 months ago (2013-02-03 12:42:24 UTC) #4

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=83bc65035b14 *** xml: omit newline at beginning of MarshalIndent output (Still valid ...

11 years, 2 months ago (2013-02-03 16:21:15 UTC) #5

LGTM

Expand All Messages | Collapse All Messages