Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 7286044: code review 7286044: cmd/dist: support for NetBSD/ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by minux1
Modified:
12 years ago
Reviewers:
CC:
dave_cheney.net, rsc, golang-dev
Visibility:
Public.

Description

cmd/dist: support for NetBSD/ARM 1. when executing a unsupported VFP instruction, the NetBSD kernel somehow doesn't report SIGILL, and instead just spin and spin, we add a alarm(2) to detect this case (albeit this is a kernel bug). 2. NetBSD/ARM's VFP11 support is not complete, so temporarily disable it. 3. The default gcc shipped with NetBSD-current mis-optimizes our code at -O2, so lower the optimization level to -O1 on NetBSD/ARM.

Patch Set 1 #

Patch Set 2 : diff -r f9987258f37a https://code.google.com/p/go/ #

Total comments: 2

Patch Set 3 : diff -r 6837136b5df8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 4b16fb118e08 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 2b17033f6f17 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 677c9ac552ac https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/cmd/dist/arm.c View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M src/cmd/dist/build.c View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/cmd/dist/unix.c View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Not tested, but SGTM. Please consider adding the same exceptions for __FreeBSD__ https://codereview.appspot.com/7286044/diff/2001/src/cmd/dist/arm.c File src/cmd/dist/arm.c ...
12 years, 1 month ago (2013-02-03 23:55:42 UTC) #1
rsc
LGTM
12 years, 1 month ago (2013-02-08 20:07:14 UTC) #2
minux1
Hello dave@cheney.net, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years ago (2013-03-02 22:50:11 UTC) #3
minux1
*** Submitted as https://code.google.com/p/go/source/detail?r=c1c2750f9aba *** cmd/dist: support for NetBSD/ARM 1. when executing a unsupported VFP ...
12 years ago (2013-03-02 22:50:30 UTC) #4
dave_cheney.net
LGTM. Untested, but I'm sure you have tested it. On 03/03/2013, at 9:50, minux.ma@gmail.com wrote: ...
12 years ago (2013-03-02 23:00:21 UTC) #5
minux1
12 years ago (2013-03-02 23:02:32 UTC) #6
On Sun, Mar 3, 2013 at 6:59 AM, Dave Cheney <dave@cheney.net> wrote:

> LGTM. Untested, but I'm sure you have tested it.
>
the new qemu builder actually supports VFPv1 (GOARM=6).
but for RPI, we stil have to use soft FP, sadly.

>
> On 03/03/2013, at 9:50, minux.ma@gmail.com wrote:
>
> > +    // FreeBSD also have broken VFP support, so disable VFP also
> > +    // on FreeBSD.
>
> // VFPv2 support is currently broken on FreeBSD, so disable all VFP on
> FreeBSD.
>
> I have heard that it is just the kernel support for v2, aka RPi, v3 is
> reported to work but images for beaglebones and pandaboards are hard to
> come by and unstable.

Does GOARM=6 work for FreeBSD on RPI?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b