ssh/terminal: add darwin support.
terminal contains a number of utility functions that are currently only
implemented for Linux. Darwin uses different named constants for
getting and setting the terminal state so this change splits them off
as constants and defines them for each arch.
On Sunday, February 3, 2013, agl wrote: > > Description: > ssh/terminal: add darwin support. ...
11 years, 1 month ago
(2013-02-02 20:09:05 UTC)
#2
On Sunday, February 3, 2013, agl wrote:
>
> Description:
> ssh/terminal: add darwin support.
>
> terminal contains a number of utility functions that are currently only
> implemented for Linux. This change also implements them for Darwin.
> However, Darwin doesn't provide two of the ioctls that Linux does:
> TCGETS and TCSETS. Rather we have to use cgo to call the libc functions
> that implement the same behaviour.
>
use TIOCGETA for tcgetattr().
On Sat, Feb 2, 2013 at 3:09 PM, minux <minux.ma@gmail.com> wrote: > use TIOCGETA for ...
11 years, 1 month ago
(2013-02-02 20:23:09 UTC)
#3
On Sat, Feb 2, 2013 at 3:09 PM, minux <minux.ma@gmail.com> wrote:
> use TIOCGETA for tcgetattr().
Thanks. I wish searching had turned that up!
CL updated.
Cheers
AGL
code LGTM. i suggest rename util_darwin.go to util_bsd.go, as i think the all *BSD use ...
11 years, 1 month ago
(2013-02-02 20:34:42 UTC)
#4
code LGTM.
i suggest rename util_darwin.go to util_bsd.go, as i think
the all *BSD use the same constants (althrough we need to
include Termios to syscall package for *BSD).
On Sat, Feb 2, 2013 at 3:34 PM, <minux.ma@gmail.com> wrote: > i suggest rename util_darwin.go ...
11 years, 1 month ago
(2013-02-02 22:28:45 UTC)
#5
On Sat, Feb 2, 2013 at 3:34 PM, <minux.ma@gmail.com> wrote:
> i suggest rename util_darwin.go to util_bsd.go, as i think
> the all *BSD use the same constants (althrough we need to
> include Termios to syscall package for *BSD).
You mean with a +build darwin for now? Otherwise all the BSDs will
fail to build until their syscall has been updated, right?
Cheers
AGL
On Sun, Feb 3, 2013 at 6:28 AM, Adam Langley <agl@golang.org> wrote: > On Sat, ...
11 years, 1 month ago
(2013-02-02 22:31:57 UTC)
#6
On Sun, Feb 3, 2013 at 6:28 AM, Adam Langley <agl@golang.org> wrote:
> On Sat, Feb 2, 2013 at 3:34 PM, <minux.ma@gmail.com> wrote:
> > i suggest rename util_darwin.go to util_bsd.go, as i think
> > the all *BSD use the same constants (althrough we need to
> > include Termios to syscall package for *BSD).
>
> You mean with a +build darwin for now? Otherwise all the BSDs will
> fail to build until their syscall has been updated, right?
>
yes. once we added struct Termios to syscall package for other BSDs,
we can update the build tags.
*** Submitted as https://code.google.com/p/go/source/detail?r=75e869cbf335&repo=crypto *** ssh/terminal: add darwin support. terminal contains a number of utility ...
11 years, 1 month ago
(2013-02-04 15:36:23 UTC)
#7
*** Submitted as
https://code.google.com/p/go/source/detail?r=75e869cbf335&repo=crypto ***
ssh/terminal: add darwin support.
terminal contains a number of utility functions that are currently only
implemented for Linux. Darwin uses different named constants for
getting and setting the terminal state so this change splits them off
as constants and defines them for each arch.
R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7286043
Issue 7286043: code review 7286043: ssh/terminal: add darwin support.
(Closed)
Created 11 years, 1 month ago by agl1
Modified 11 years, 1 month ago
Reviewers:
Base URL:
Comments: 0