Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(530)

Issue 7275049: code review 7275049: runtime: limit number of OS threads (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by rick
Modified:
11 years, 2 months ago
Reviewers:
rsc, golang-dev
Visibility:
Public.

Description

runtime: limit number of OS threads Add a semaphore around entersyscall/exitsyscall to limit the maximum number of OS threads to 256. The new runtime.MaxOSThreads func allows the limit to be changed. Fixes issue 4056.

Patch Set 1 #

Patch Set 2 : diff -r e2f9b9a58240 https://code.google.com/p/go #

Patch Set 3 : diff -r e2f9b9a58240 https://code.google.com/p/go #

Patch Set 4 : diff -r 85d759cdb33d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M src/pkg/runtime/debug.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 3 4 chunks +7 lines, -1 line 0 comments Download
M src/pkg/runtime/proc_test.go View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime1.goc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rick
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 2 months ago (2013-02-04 13:30:20 UTC) #1
rsc
The system call entry and exit are performance sensitive. I'd like to think about this ...
11 years, 2 months ago (2013-02-05 04:01:07 UTC) #2
rick
PTAL I got rid of the semaphore. Does this version address your performance concerns? Thanks.
11 years, 2 months ago (2013-02-09 05:44:29 UTC) #3
rsc
Now the code has a race. I think it would probably be better to leave ...
11 years, 2 months ago (2013-02-13 21:43:40 UTC) #4
rick
On 2013/02/13 21:43:40, rsc wrote: > Now the code has a race. > > I ...
11 years, 2 months ago (2013-02-14 22:53:06 UTC) #5
rick
11 years, 2 months ago (2013-02-14 22:53:29 UTC) #6
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b