code review 72590044: runtime: comment out breakpoint in windows/386 sighandler

runtime: comment out breakpoint in windows/386 sighandler

This code being buggy is the only explanation I can come up
with for issue 7325. It's probably not, but the only alternative
is a Windows kernel bug. Comment this out to see what breaks
or gets fixed.

Update issue 7325

[rsc, 2014-03-07 19:10:46]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-03-07 19:16:57]

LGTM but can't you just try it on the windows-386 builder directly?



On Fri, Mar 7, 2014 at 11:10 AM, <rsc@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime: comment out breakpoint in windows/386 sighandler
>
> This code being buggy is the only explanation I can come up
> with for issue 7325. It's probably not, but the only alternative
> is a Windows kernel bug. Comment this out to see what breaks
> or gets fixed.
>
> Update issue 7325
>
> Please review this at https://codereview.appspot.com/72590044/
>
> Affected files (+2, -0 lines):
>   M src/pkg/runtime/os_windows_386.c
>
>
> Index: src/pkg/runtime/os_windows_386.c
> ===================================================================
> --- a/src/pkg/runtime/os_windows_386.c
> +++ b/src/pkg/runtime/os_windows_386.c
> @@ -30,11 +30,13 @@
>         bool crash;
>         uintptr *sp;
>
> +       /*
>         switch(info->ExceptionCode) {
>         case EXCEPTION_BREAKPOINT:
>                 r->Eip--;       // because 8l generates 2 bytes for INT3
>                 return 1;
>         }
> +       */
>
>         if(gp != nil && runtime·issigpanic(info->ExceptionCode)) {
>                 // Make it look like a call to the signal func.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-03-07 19:22:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=ef9dd517f626 ***

runtime: comment out breakpoint in windows/386 sighandler

This code being buggy is the only explanation I can come up
with for issue 7325. It's probably not, but the only alternative
is a Windows kernel bug. Comment this out to see what breaks
or gets fixed.

Update issue 7325

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/72590044

[rsc, 2014-03-07 19:22:52]

On Fri, Mar 7, 2014 at 2:16 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> LGTM but can't you just try it on the windows-386 builder directly?
>

i can't make it happen for me on the builder. i've tried. it only seems to
happen when the builder is running actual builds. there is a long
discussion on issue 7325.

[gobot, 2014-03-07 19:59:28]

This CL appears to have broken the linux-amd64 builder.